Skip to content

fix(auth): getUserIdentities null guard and validateUUID error envelope - #2555

Closed
PedroHenrique0713 wants to merge 2 commits into
supabase:masterfrom
PedroHenrique0713:fix/admin-validate-and-identities2
Closed

fix(auth): getUserIdentities null guard and validateUUID error envelope#2555
PedroHenrique0713 wants to merge 2 commits into
supabase:masterfrom
PedroHenrique0713:fix/admin-validate-and-identities2

Conversation

@PedroHenrique0713

Copy link
Copy Markdown
Contributor

Fix 2 auth-js bugs: getUserIdentities crashes when no session (null user → TypeError), getUserById validateUUID throws outside try/catch bypassing { data, error } envelope.

handleOperation's documented contract is to return { data, error } tuples.
When a non-StorageError was thrown, the error was re-thrown instead of
being wrapped, breaking the expected caller contract.
@PedroHenrique0713
PedroHenrique0713 requested review from a team as code owners July 23, 2026 21:23
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@PedroHenrique0713, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a1304aff-30b3-4432-9f80-b9f8b5f4fc7a

📥 Commits

Reviewing files that changed from the base of the PR and between 485695f and bdef539.

📒 Files selected for processing (3)
  • packages/core/auth-js/src/GoTrueAdminApi.ts
  • packages/core/auth-js/src/GoTrueClient.ts
  • packages/core/storage-js/src/lib/common/BaseApiClient.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PedroHenrique0713

Copy link
Copy Markdown
Contributor Author

Closing this one. I opened it today as part of a batch of stacked branches, and it went out without the test coverage I normally include. I already have open PRs in this repo (#2514, #2518, #2529, #2530) that carry unit and end-to-end tests, and I would rather keep the review queue focused on those. If this fix still applies, I will resubmit it properly tested on top of master. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant